Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field List Item Styles Across Discover & Lens #174122

Open
Tracked by #194790
MichaelMarcialis opened this issue Jan 2, 2024 · 2 comments
Open
Tracked by #194790

Field List Item Styles Across Discover & Lens #174122

MichaelMarcialis opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
Feature:Discover Discover Application Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Jan 2, 2024

In the latest Discover design refresh concepts provided by @andreadelrio and I, we suggested that each field list item should be 32px tall with no margin in between siblings and 12px font size (across both the Discover and Lens apps). Discover currently styles these field list items to be 24px tall with 2px margin between siblings and 12px font size. Lens currently styles field list items to be 32px tall with 4px margin between siblings and 14px font size. While I can appreciate the desire for greater data density in the Discover use case, I'm not fond of the overly small vertical drag real estate such a small field list item height provides. I'm also not fond of the style inconsistencies between field lists in the Discover and Lens apps.

While I know there has been some friendly disagreement in the past regarding the ideal field list item height across both apps, I think now is a good time for us to unify these field list item styles to be consistent across both Discover and Lens using our design suggestions above. Doing so provides what I would consider to be minimal safe real estate with which users could grab and drag an item (though others tend to suggest even larger, ~38–40px minimum). While I understand there is a desire for high density in the field list, I think this needs to be balanced against usability.

The end result of this suggested change also isn't very dramatic on the field density topic. For example, in a 1440x1024 viewport, the current field list item styles show 27.5 fields in Discover. Updating the styles to match our design suggestions show 23 fields in Discover. I'm personally OK having 4.5 fields falling below the fold for the sake of better drag-and-drop usability.

CCing @jughosta.

Originating comment: #171572 (comment)

@MichaelMarcialis MichaelMarcialis added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants