Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Sort panels and keys on save #167537

Open
ThomThomson opened this issue Sep 28, 2023 · 4 comments
Open

[Dashboard] Sort panels and keys on save #167537

ThomThomson opened this issue Sep 28, 2023 · 4 comments
Labels
blocked enhancement New value added to drive a business result Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Problem

When saving a dashboard, the panels, and the keys within them are un-sorted. This means that it's impossible to properly diff a Dashboard saved object.

Solution

On save, we should order the panels based on their positions in the grid, then order the keys inside alphabetically.
@ThomThomson ThomThomson added the enhancement New value added to drive a business result label Sep 28, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 28, 2023
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed needs-team Issues missing a team label labels Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added the loe:medium Medium Level of Effort label Sep 28, 2023
@thomasneirynck thomasneirynck added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 3, 2023
@thomasneirynck
Copy link
Contributor

Changing this to high impact. It is one of these issues that reduces real friction for an important use-case of the stack.

@thomasneirynck
Copy link
Contributor

This is an example of how unsorted keys can cause cluttered and unreadable diffs

image

@thomasneirynck thomasneirynck mentioned this issue Jan 9, 2024
Open
@ThomThomson ThomThomson mentioned this issue Jan 16, 2024
Open
@ThomThomson
Copy link
Contributor Author

Blocked on #174949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement New value added to drive a business result Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thomasneirynck @ThomThomson @elasticmachine