Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Improve overall rule diff algorithm #166388

Closed
2 tasks
banderror opened this issue Sep 13, 2023 · 5 comments
Closed
2 tasks

[Security Solution] Improve overall rule diff algorithm #166388

banderror opened this issue Sep 13, 2023 · 5 comments
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area performance refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

banderror commented Sep 13, 2023 •
edited
Loading

UPDATE: Splitted into:

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168
Related to: #148189

Summary

  • Split diff calculation into async chunks to improve server-side performance and unblock the event loop (comment).
  • In extractDiffableCommonFields, apply the same default values to the rule as in convertCreateAPIToInternalSchema, which means reuse the existing code. That would be helpful to ensure that defaults in extractDiffableCommonFields and convertCreateAPIToInternalSchema do not diverge over time. (comment).
@banderror banderror added performance refactoring Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Sep 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror mentioned this issue Sep 13, 2023
Closed
2 tasks
@mbudge
Copy link

mbudge commented Nov 28, 2023

When are we going to be able to customise pre-built rules without cloning? We can’t update cloned rules without loosing customisations like index patterns, timestamp override and rule exceptions.

@banderror banderror mentioned this issue Jan 3, 2024
Open
@jpdjere
Copy link
Contributor

jpdjere commented Apr 5, 2024

@mbudge The team is actively working on this feature. You can track progress in this ticket.

@jpdjere
Copy link
Contributor

jpdjere commented Apr 5, 2024

Closing ticket in favour of two parts:

@jpdjere jpdjere closed this as completed Apr 5, 2024
@banderror banderror closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area performance refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpdjere @banderror @mbudge @elasticmachine