[osquery] Migrate all usages of EuiPage*_Deprecated

[cee-chen]

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have a usages of EuiPageContent_Deprecated in the osquery plugin, which you are listed in a codeowner of:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Fosquery%2F&type=code

How

• Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
• You can also see more examples of layout conversions in the original EuiPageTemplate PR:
  [Feature] EuiPage and EuiPageTemplate Updates eui#5768
• Here's a quick conversion map of components that approximately translate to their new equivalents:
  • EuiPageTemplate_Deprecated -> EuiPageTemplate
  • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
  • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
  • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
  • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
  • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

[elasticmachine]

Pinging @elastic/eui-team (EUI)

[elasticmachine]

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

[cee-chen]

The above is our boilerplate guidance for all teams across Kibana still using deprecated page templates, but I notice specifically for OSQuery that your usage is actually within your main <App> wrapper.

If it makes any sense to do so, it might be worth investigating moving towards KibanaPageTemplate/EuiPageTemplate instead of individual page components. In particular from what I briefly skimmed, you may be interested in the template = centeredBody and template = centeredContent with sidebar collapsed examples listed in elastic/eui#5768.

If it doesn't make sense to use the full template, no worries, a basic EuiPageSection conversion should likely also suffice.

[tomsonpl]

@cee-chen Thanks, I'll take care of this 👍

[cee-chen]

Hey @tomsonpl! It looks like osquery no longer has any deprecated usages remaining 🎉 Should I go ahead and close this issue out?

[tomsonpl]

@cee-chen Yeah sure, sorry I forgot about closing it, but it's done :)

[tomsonpl]

DONE :osquery: