Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] make visualization_ui_components plugin a static package #161140

Closed
drewdaemon opened this issue Jul 3, 2023 · 1 comment · Fixed by #161500
Closed

[Lens] make visualization_ui_components plugin a static package #161140

drewdaemon opened this issue Jul 3, 2023 · 1 comment · Fixed by #161500
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Jul 3, 2023

Describe the feature:
As we move more of our code to a stateless context, we reap benefits of increased simplicity and verifiability, leading to higher quality and stability.

The visualization_ui_components plugin was created to make Lens UI components available outside of Lens as the need arises (e.g. #158774).

It was originally planned as a static package, but I made it a plugin because of a dependency on a Unified Search component which, being in a public context, could not be imported from a static package context.

However, most of the current plugin could be pulled out into a static package following the pattern used in #158008 where we put what we can in static packages that are then injected with Kibana dependencies via a slim plugin wrapper.

@drewdaemon drewdaemon added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants