Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX Tweaks for the Add Data UI #15961

Closed
alexfrancoeur opened this issue Jan 10, 2018 · 6 comments
Closed

UI/UX Tweaks for the Add Data UI #15961

alexfrancoeur opened this issue Jan 10, 2018 · 6 comments
Labels
Feature:Add Data Add Data and sample data feature on Home Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Jan 10, 2018

From #14749 (review)

@snide & @gchaps may be able to chime in here, but is there a better way to surface instructions that are not code? Visually, seem to blend in with the title a bit more than I'd expect but this may just be a bit nitpicky on my part.

screen shot 2018-01-08 at 2 43 21 pm

screen shot 2018-01-08 at 2 43 43 pm

I'm assuming this is because the Add Data view is centered, but it seems odd to me that the breadcrumb is in the center of the page rather than the top left.

screen shot 2018-01-08 at 2 43 57 pm

vs.

screen shot 2018-01-08 at 2 44 09 pm

If we were able to open any links from this tutorial I think it'd make a much cleaner experience if it was a new tab vs. a redirect. That way you don't lose context of the instructions or redirect away from Kibana.

jan-08-2018 14-50-11

Are we still providing links to the assets / dashboard installed at the end of the instructions?

Last but not least, I know @formgeist is working on some icons. We should have those shortly for the list and tutorial views.
Updated: We now have icons provided by Design (see below), we'll need these introduced for the appropriate tutorials both in the list view and tutorial view as well as using an empty icon for those we do not have an icon for

cc: @nreese

@formgeist
Copy link
Contributor

@alexfrancoeur The icons you're missing is the fallback/default icon mentioned here https://github.com/elastic/Design/issues/754#issuecomment-356273939? @snide added the Apache, Nginx and MySQL icons to EUI (v.0.0.11)
screenshot 2018-01-10 16 09 11

@alexfrancoeur
Copy link
Author

woops, I meant to remove that comment. Thanks @formgeist!

@formgeist
Copy link
Contributor

By the way, it looks like the titles are pushed too far right, probably because of the steps.

34689253-ddc7bc92-f482-11e7-803b-944fd4ea4624

@alexfrancoeur
Copy link
Author

Text review being tracked here: #16003

@snide
Copy link
Contributor

snide commented Jan 11, 2018

A lot of the visual errors mentioned here are fixed in #16005

@alexfrancoeur alexfrancoeur added the Feature:Add Data Add Data and sample data feature on Home label Jan 25, 2018
@alexfrancoeur
Copy link
Author

I think we can close this out with what was merged in #16005

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Add Data Add Data and sample data feature on Home Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants