-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX Tweaks for the Add Data UI #15961
Comments
@alexfrancoeur The icons you're missing is the fallback/default icon mentioned here https://github.com/elastic/Design/issues/754#issuecomment-356273939? @snide added the Apache, Nginx and MySQL icons to EUI (v.0.0.11) |
woops, I meant to remove that comment. Thanks @formgeist! |
Text review being tracked here: #16003 |
A lot of the visual errors mentioned here are fixed in #16005 |
I think we can close this out with what was merged in #16005 |
From #14749 (review)
@snide & @gchaps may be able to chime in here, but is there a better way to surface instructions that are not code? Visually, seem to blend in with the title a bit more than I'd expect but this may just be a bit nitpicky on my part.
I'm assuming this is because the Add Data view is centered, but it seems odd to me that the breadcrumb is in the center of the page rather than the top left.
vs.
If we were able to open any links from this tutorial I think it'd make a much cleaner experience if it was a new tab vs. a redirect. That way you don't lose context of the instructions or redirect away from Kibana.
Are we still providing links to the assets / dashboard installed at the end of the instructions?
Last but not least, I know @formgeist is working on some icons. We should have those shortly for the list and tutorial views.Updated: We now have icons provided by Design (see below), we'll need these introduced for the appropriate tutorials both in the list view and tutorial view as well as using an empty icon for those we do not have an icon for
cc: @nreese
The text was updated successfully, but these errors were encountered: