Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Evaluate validation schema for bulk project monitor api #159583

Closed
Tracked by #153396 ...
dominiqueclarke opened this issue Jun 13, 2023 · 2 comments
Closed
Tracked by #153396 ...
Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0

Comments

@dominiqueclarke
Copy link
Contributor

Describe the feature:
We do not currently have any route-side kbn-schema defined for the monitor client contract for project monitors. However, we do use io-ts to define the client contract and the monitor SO configured from it are valid.

We should see if there's any opportunity to use kbn-schema for monitor client contract, or if it's best to continue using io-ts exclusively since the monitor types are so complex.

We should also ensure that the client side type currently used by io-ts is strict enough.

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0 labels Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor

i don't think it's worth to add kbn-schema validation since we already have io-ts validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

No branches or pull requests

3 participants