Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User shouldn't be able to click reset on panel settings for dashboard panels without making any changes #159422

Closed
bhavyarm opened this issue Jun 9, 2023 · 2 comments · Fixed by #159430
Closed

User shouldn't be able to click reset on panel settings for dashboard panels without making any changes #159422

bhavyarm opened this issue Jun 9, 2023 · 2 comments · Fixed by #159430
Assignees
@AbrarAlHasan
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Jun 9, 2023

Kibana version: 8.8.1

Elasticsearch version: 8.8.1

Browser version: chrome latest

Describe the bug: User can click on reset button on panel settings for title and description without making any changes on dashboard panels. Can we disable the active status of these buttons when there are no changes?

active_status_buttons.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 9, 2023
@Heenawter Heenawter added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. good first issue low hanging fruit and removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 9, 2023
@AbrarAlHasan
Copy link
Contributor

AbrarAlHasan commented Jun 10, 2023 •
edited
Loading

Can I get this Assigned to me. I have Resolved this Issue.
I have attached the Video for the Reference

Screen.Recording.2023-06-10.at.11.21.35.AM.1.mp4

@AbrarAlHasan AbrarAlHasan mentioned this issue Jun 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbrarAlHasan AbrarAlHasan

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dashboard Reset button disable AbrarAlHasan/kibana
5 participants
@bhavyarm @Heenawter @elasticmachine @kibanamachine @AbrarAlHasan