Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rule registry] Remove usages of refresh: true #158139

Closed
Tracked by #158134
lukeelmers opened this issue May 19, 2023 · 2 comments · Fixed by #159252
Closed
Tracked by #158134

[rule registry] Remove usages of refresh: true #158139

lukeelmers opened this issue May 19, 2023 · 2 comments · Fixed by #159252
Assignees
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@lukeelmers
Copy link
Member

There are two usages of refresh: true in the rule registry files. These should be changed to refresh: wait_for or refresh: false:

1. x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
2. x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts

This is particularly important for features which exist in serverless, though self-managed deployments would benefit from this change as well. See #158134 for more details.

Notes on each route from @kobelb:

  1. Not used - can be removed
  2. ~10x per minute on rule preview requests with suppression enabled - can be removed - Refreshing allows the rule preview API to work much faster, but we could limit previews to not work with suppression or accept that the API will be slower when suppression is enabled
@lukeelmers lukeelmers added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label May 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote
Copy link
Contributor

cc @heespi this is the GitHub issue we'll use to remove the usages of refresh: true from the rule registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants