-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shard error message formatting #156645
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Thx @sophiec20 for providing additional feedback, I do agree we should aim to fix this dated UI. Apart from the layout, I think the information presented here to debug shard errors, something like this would be useful for CCS failures, telling users about timeouts in certain CCS clusters or something like this (Once this information would be available in a search request result, which isn't currently the case) |
Yes, and we can make it better in increments, starting with a more succinct, cleaner and simpler presentation of today's elasticsearch errors. As a follow up, we can work with es to improve error handling. |
- Closes #156645 ## Summary This PR updates UI of shards error modal. ### Updated design <img width="500" alt="Screenshot 2023-07-07 at 10 05 00" src="https://github.com/elastic/kibana/assets/1415710/a099a436-61fd-4522-b231-88a0d1179061"> ![Jul-07-2023 10-20-13](https://github.com/elastic/kibana/assets/1415710/23069476-9aae-4c76-9e39-586a382dcf70) ### Before <img width="500" alt="image 2" src="https://github.com/elastic/kibana/assets/4016496/d3c067d9-2d18-4fcc-8db0-573defcb9b44"> For testing, please follow instruction from #41649 and drop `targetfield` on Lens page. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Andrea Del Rio <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
- Closes elastic#156645 ## Summary This PR updates UI of shards error modal. ### Updated design <img width="500" alt="Screenshot 2023-07-07 at 10 05 00" src="https://github.com/elastic/kibana/assets/1415710/a099a436-61fd-4522-b231-88a0d1179061"> ![Jul-07-2023 10-20-13](https://github.com/elastic/kibana/assets/1415710/23069476-9aae-4c76-9e39-586a382dcf70) ### Before <img width="500" alt="image 2" src="https://github.com/elastic/kibana/assets/4016496/d3c067d9-2d18-4fcc-8db0-573defcb9b44"> For testing, please follow instruction from elastic#41649 and drop `targetfield` on Lens page. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Andrea Del Rio <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
We introduced a modal providing details to shard errors in v7.4.0 with PR #41649
It allows users to get details about shard errors, before just the message "x of y shards failed" was detailed.
Here's how the modal looks like
The following should be improved
Row expansion
Table
The text was updated successfully, but these errors were encountered: