Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] add attribute step="any" to EuiFieldNumber inputs that accept decimals #156540

Closed
nreese opened this issue May 3, 2023 · 1 comment
Closed

[maps] add attribute step="any" to EuiFieldNumber inputs that accept decimals #156540

nreese opened this issue May 3, 2023 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented May 3, 2023

EUI v77.2.2 upgrade includes a visual breaking change to EuiFieldNumber that displays an error icon if the input fails browser validation. Maps does not correctly set step="any" for EuiFieldNumber inputs that accept doubles.

We need to audit all usages of EuiFieldNumber in Maps application and add step="any" attribute for those that accept decimals
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Maps labels May 3, 2023
@nreese nreese mentioned this issue May 3, 2023
Merged
@nreese
Copy link
Contributor Author

nreese commented May 17, 2023

No longer needed, EUI 80.0.0 defaults step to "any"

@nreese nreese closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nreese