Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile System Theme #155945

Open
kc13greiner opened this issue Apr 26, 2023 · 6 comments
Open

User Profile System Theme #155945

kc13greiner opened this issue Apr 26, 2023 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Security/User Profile Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kc13greiner
Copy link
Contributor

kc13greiner commented Apr 26, 2023

Currently, users can only choose 'Space default', 'Light', and 'Dark' for their desired theme.

Users should have a setting that matches their OS setting; this option was originally listed in early mockups

This is non-trivial as the OS Theme setting is retrieved from the browser, but KB calculates the style sheet paths and scss variables on the server.

This is blocked on Kibana-wide support for using the system theme: #89340

@kc13greiner kc13greiner added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result labels Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Apr 27, 2023

I updated the issue description to note this is blocked on #89340

@JasonStoltz
Copy link
Member

@legrego @pgayvallet @kc13greiner Now that #89340 has been implemented, is there still work to do here?

If "Dark Mode: Sync with system" set at the System level, then is there still a need to have this option at the user level?

@JasonStoltz
Copy link
Member

Separate question, is this issue a duplicate of #173895?

@pgayvallet
Copy link
Contributor

Separate question, is this issue a duplicate of #173895?

Looks like it is. I wasn't aware we already had an issue when I opened #173895. I'll let the security folks confirm and close one of the two issue if necessary.

@legrego
Copy link
Member

legrego commented Jul 29, 2024

I closed #173895 as a duplicate, and have marked this as unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Security/User Profile Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

5 participants