Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Get Expensive Queries Setting With Internal User #155425

Closed
ThomThomson opened this issue Apr 20, 2023 · 2 comments · Fixed by #155430
Closed

[Controls] Get Expensive Queries Setting With Internal User #155425

ThomThomson opened this issue Apr 20, 2023 · 2 comments · Fixed by #155430
Assignees
@ThomThomson
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Apr 20, 2023 •
edited
Loading

#155082 added a fallback to assume allow_expensive_queries is on when the user doesn't have the manage permission required to check if it's on or not. The problem with this solution is that it could result in errors if allow_expensive_queries is off but the user doesn't have permission to check.

Because even cloud / okta users are missing this manage permission, we should explore another way to get this information. One idea is to potentially use the internal user instead.

If we do that, we should ensure that the endpoint is named properly, and doesn't take any post body or arguments.
@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Apr 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson self-assigned this Apr 20, 2023
@Heenawter
Copy link
Contributor

Closed by #155430

@Heenawter Heenawter linked a pull request Apr 24, 2023 that will close this issue
[Controls] Use Internal User to Get Value of allow_expensive_queries #155430
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Controls] Use Internal User to Get Value of allow_expensive_queries ThomThomson/kibana
3 participants
@Heenawter @ThomThomson @elasticmachine