Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Versioned router: configuration should allow declaring access #152276

Closed
TinaHeiligers opened this issue Feb 27, 2023 · 2 comments · Fixed by #152404
Closed

[http] Versioned router: configuration should allow declaring access #152276

TinaHeiligers opened this issue Feb 27, 2023 · 2 comments · Fixed by #152404
Assignees
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

This issue is to handle the work needed for step 2 in
[http] Prevent access to internal-only APIs when running in serverless

Note: Some (if not most) of the individual issues might need t to be handled at the same time. For now, we assume that any work specifically addressing VersionedRouters can be done in parallel.

Adapt the versioned router specification

Adapt RouteConfigOptions to:

  • Add an access parameter at the route's level
  • the parameter is required and can be set to either public or internal
  • the parameter cannot be changed between versions
@TinaHeiligers TinaHeiligers added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Epic:VersionedAPIs Kibana Versioned APIs labels Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

depends on #152269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
2 participants