Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Incorrect comments type throws error in edit exception item API call #149971

Closed
dplumlee opened this issue Jan 31, 2023 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Alerts Security Detection Alerts Area Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.2 v8.7.0

Comments

@dplumlee
Copy link
Contributor

Overview

When users edit exception items from the edit exception flyout, there is an edge case in which the close alerts checkbox causes some of the edit functionality to break on submit

Repro

  1. Open the edit exception flyout from an existing exception card
  2. Add a new comment in the exception
  3. Check the Close all alerts that match this exception checkbox
  4. Click the Edit exception button to submit the form
  5. Notice the exception successfully updated but the closing of related alerts fails with an error toast

Notes

The error occurs in this file where we send the incorrect version of the comments type via the api. In order to fix we just need to remove extraneous types from the _create_filter api call

This also stems from #149891 where some types and schemas aren't congruent, yet don't present that in code which causes errors in api calls

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team labels Jan 31, 2023
@dplumlee dplumlee self-assigned this Jan 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@marshallmain marshallmain added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v8.7.0 v8.6.2 labels Feb 9, 2023
@MadameSheema
Copy link
Member

Tested on 8.6.2-BC and is working fine!

Pending to be validated on 8.7.0-BC.

@MadameSheema
Copy link
Member

Validated on 8.7.0-BC2 and working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Alerts Security Detection Alerts Area Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.2 v8.7.0
Projects
None yet
Development

No branches or pull requests

4 participants