Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] remove toast display from data views service #149870

Closed
Tracked by #166175
mattkime opened this issue Jan 30, 2023 · 2 comments
Closed
Tracked by #166175

[data views] remove toast display from data views service #149870

mattkime opened this issue Jan 30, 2023 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mattkime
Copy link
Contributor

We'd like to remove error toasts from the data views service as the consuming APIs should be deciding the correct way to handle the errors. We should deprecate the current data views service methods that potentially display toasts and replace them with methods that pass errors. Its annoying to make mostly meaningless name changes to methods so we should consider tradeoffs.

a) Rename all toast displaying data view service methods - append 'Deprecated' to the names
b) Expose new methods with that throw errors instead of displaying them. Mark all Deprecated named methods as deprecated.
c) Provide wrapper that allows usage of new methods but toasts are being displayed by consumers. This is a way to address the technical debt and put off other UX changes.

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added enhancement New value added to drive a business result loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 30, 2023
@kertal kertal added loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Feb 1, 2023
@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 16, 2023
@kertal kertal added the Icebox label Oct 23, 2023
@kertal
Copy link
Member

kertal commented Oct 23, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants