Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Announce Kibana route changes on app change #149212

Closed
vadimkibana opened this issue Jan 19, 2023 · 2 comments · Fixed by #150461
Closed

[Accessibility] Announce Kibana route changes on app change #149212

vadimkibana opened this issue Jan 19, 2023 · 2 comments · Fixed by #150461
Assignees
@rshen91
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@vadimkibana
Copy link
Contributor

vadimkibana commented Jan 19, 2023 •
edited
Loading

Add necessary changes to the Kibana applications service such that routes are correctly announced when Kibana application is changed.

Partially addresses: #135760
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 19, 2023
@vadimkibana vadimkibana added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Jan 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 19, 2023
@vadimkibana vadimkibana mentioned this issue Jan 19, 2023
Closed
2 tasks
@1Copenut
Copy link
Contributor

The EUI docs site is a good model for how to implement this improvement using EUI components. Having the EuiScreenReaderOnly as the first element in the React root gives us a consistent place to set focus programmatically and sets us up nicely to add the skip to content link as the first user-focusable element.

@rshen91 rshen91 self-assigned this Feb 2, 2023
@rshen91 rshen91 mentioned this issue Feb 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Accessibility] Route changes announcement rshen91/kibana
4 participants
@1Copenut @elasticmachine @rshen91 @vadimkibana