Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Alerts] Make sure Rule Preview looks good on smaller screens #148968

Open
e40pud opened this issue Jan 16, 2023 · 1 comment
Open

[Security Solution][Alerts] Make sure Rule Preview looks good on smaller screens #148968

e40pud opened this issue Jan 16, 2023 · 1 comment
Labels
enhancement New value added to drive a business result Feature:Detection Rule Preview Security Solution Detection Rule Preview feature Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@e40pud
Copy link
Contributor

e40pud commented Jan 16, 2023

There are couple UI fixes we need to do to make Rule Preview look great on smaller screens:

  1. The min-size on the preview container allows for cutoff of the datepicker action button. Consider increasing the min-width ever so slightly. Or perhaps this is an overflow issue with the timepicker component?

210456759-f56554eb-ac93-45d7-8797-ea83fc2de02c

  1. On small resolution new implementation become difficult to use. Maybe stacking it on each other on small resolution can be viable solution?

210771756-ded865aa-173e-49cc-ace7-9d2caff617b1

These issues were discovered while testing these changes.

cc @vitaliidm @spong
@e40pud e40pud added the enhancement New value added to drive a business result label Jan 16, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 16, 2023
@e40pud e40pud mentioned this issue Jan 16, 2023
Merged
@jsanz jsanz added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Jan 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 16, 2023
@vitaliidm vitaliidm added Team:Detection Alerts Security Detection Alerts Area Team Feature:Detection Rule Preview Security Solution Detection Rule Preview feature labels Jan 16, 2023
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Detection Alerts Security Detection Alerts Area Team labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Detection Rule Preview Security Solution Detection Rule Preview feature Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jsanz @e40pud @yctercero @elasticmachine @vitaliidm