Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Enable loading and saving of unified search queries #148310

Closed
Tracked by #142714 ...
weltenwort opened this issue Jan 3, 2023 · 5 comments
Closed
Tracked by #142714 ...

[Logs UI] Enable loading and saving of unified search queries #148310

weltenwort opened this issue Jan 3, 2023 · 5 comments
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Jan 3, 2023

📓 Summary

We want to support the "saved query" feature of the unified search bar in the Logs UI. To enable this we want to extend the LogStreamQuery state machine with the ability to interact with the saved query service.

✔️ Acceptance criteria

  • The LogStreamQuery state machine can load a saved query on initialization.
  • The loaded saved query id is persisted in the URL.
  • The page state stays consistent in the sense that no incorrect query or filters are applied while loading the saved query is in progress.
  • The query, filter and time state in the url overrides the query, filter and time retrieved from the saved query.
  • The loaded saved query can be updated with new query, filter and time state via the unified search bar menu.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@weltenwort weltenwort changed the title [Logs UI] Enable loading and saving queries [Logs UI] Enable loading and saving of unified search queries Jan 3, 2023
@weltenwort
Copy link
Member Author

@Kerry350 I'd appreciate your feedback on the ACs before we call this "ready"

@Kerry350
Copy link
Contributor

@weltenwort They look good to me, except maybe:

(Optional) The query and filter state in the url is only set when either differs from the saved query state.

We might want to discuss this one as it has ramifications for when we reload the page again and we then have the discrepancy over precedence.

@weltenwort
Copy link
Member Author

weltenwort commented Jan 16, 2023

Good point! Maybe we should replace this with a point that clarifies the precedence instead.

@weltenwort weltenwort added needs-refinement A reason and acceptance criteria need to be defined for this issue and removed needs-refinement A reason and acceptance criteria need to be defined for this issue labels Jan 16, 2023
@smith
Copy link
Contributor

smith commented Jun 26, 2023

We're not planning on completing this at this time.

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants