Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Add numeral support for duration fields #14612

Closed
shaharmor opened this issue Oct 26, 2017 · 1 comment
Closed

[TSVB] Add numeral support for duration fields #14612

shaharmor opened this issue Oct 26, 2017 · 1 comment
Labels
Feature:FieldFormatters Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@shaharmor
Copy link
Contributor

Kibana version: 6.0.0-rc1

Description of the problem including expected versus actual behavior:
When formatting a metric visualization as a duration (I.E from milliseconds to minutes), the number isn't formatted with numeral.js which makes it just a long number (Without commas).
Instead of having the decimal places option, we can replace it with a numeral.js format which will just run numeral(value).format(format) after the duration conversion here: https://github.com/elastic/kibana/blob/6.x/src/core_plugins/metrics/public/components/lib/tick_formatter.js#L37

Steps to reproduce:

  1. Create a metric TSVB visualization
  2. Change field formatter to duration
  3. See number is not formatted with commas
@jbudz jbudz added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Oct 30, 2017
@ppisljar ppisljar added the Feature:TSVB TSVB (Time Series Visual Builder) label Nov 23, 2017
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@stratoula
Copy link
Contributor

Duplicate of #153378

@stratoula stratoula marked this as a duplicate of #153378 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:FieldFormatters Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants