Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics UI] Track state for last test run separatedly from the test run table #144252

Closed
afgomez opened this issue Oct 31, 2022 · 1 comment · Fixed by #144269
Closed

[Synthetics UI] Track state for last test run separatedly from the test run table #144252

afgomez opened this issue Oct 31, 2022 · 1 comment · Fixed by #144269
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0

Comments

@afgomez
Copy link
Contributor

afgomez commented Oct 31, 2022

In the redux store we keep the information for the test runs in monitorDetails.pings. This is used for both the test run table, and the latest test run block. We treat the first ping as the last test run.

In #144029 we added pagination to the test run table. The pagination overwrites the contents of the store in monitorDetails.pings when the user switches pages. That means that for any page other than the first one, the first element in the monitorDetails.pings array is no longer the latest test run. This was commented as a known issue in the linked PR.

After speaking with @shahzad31 the best solution would be to keep the state for the last test run block separate from the list of pings. This is the issue to implement such change.

@afgomez afgomez added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 31, 2022
@afgomez afgomez self-assigned this Oct 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants