Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Monitors with public/private locations fail to 'run now' in private location #140768

Closed
andrewvc opened this issue Sep 14, 2022 · 6 comments · Fixed by #142004
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability uptime v8.5.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Sep 14, 2022

Creating a monitor with both public and private locations selected works fine, but using the run now feature attempts to 'run now' in all locations. The private location never returns results in the GUI, we should never show a status for that location.

ACs

  • Run Now is available for any monitor configured to run on one or more public locations
    • Irrespective of it also configured to run on a private location
  • When using Run Now, it only attempts to run the test on the public location(s) (not any private locations is may be configured to run on)
  • Run Now behaviour should be consistent from:
    • Monitors (Overview) page in Uptime (monitor list, Test now column
    • Add/edit screen in Uptime (Run test button)
@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability uptime v8.5.0 labels Sep 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@paulb-elastic
Copy link
Contributor

@andrewvc is this with main? Thinking about how this relates to #138862 where it suggests it's not available (cc @awahab07)

I think the summary should be that:

  • Run Now is available for any monitor configured to run on one or more public locations
    • Irrespective of it also configured to run on a private location
  • When using Run Now, it only attempts to run the test on the public location(s) (not any private locations is may be configured to run on)
  • Run Now behaviour should be consistent from:
    • Monitors (Overview) page in Uptime (monitor list, Test now column
    • Add/edit screen in Uptime (Run test button)

It would be good to consolidate these two tickets if agreed.

@andrewvc
Copy link
Contributor Author

I think that description is right, I've updated the top comment with your text @paulb-elastic . @justinkambic hit the issue while recording our 8.4 release video, which I believe was on an 8.4 stack. I'm a bit confused since he could run it using test now.

You can see the bad behavior here: https://youtu.be/lG4OcV314_k?t=1612

@justinkambic
Copy link
Contributor

Yes we were running an 8.4.1 stack when we recorded the release video. We attempted to use Run Now, which we showed while configuring the Private Location toward the end, and had to backpedal from that improvised part of the demo when it failed.

@andrewvc
Copy link
Contributor Author

CC @awahab07 since he's the author of the other issue

@awahab07
Copy link
Contributor

I'll look into both of the issues together. I need to confirm if both of the issues occur consistently and if they are related. The problem mentioned in issue #138862 depends on the order of records fetched, so it's not consistent, but definitely need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability uptime v8.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants