Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptInBanner is rendering without theme, no dark mode support #139883

Closed
matschaffer opened this issue Sep 1, 2022 · 3 comments · Fixed by #139911
Closed

OptInBanner is rendering without theme, no dark mode support #139883

matschaffer opened this issue Sep 1, 2022 · 3 comments · Fixed by #139911
Assignees
@pgayvallet
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@matschaffer
Copy link
Contributor

Screen Shot 2022-09-01 at 14 34 04

kibana/src/plugins/telemetry/public/services/telemetry_notifications/render_opt_in_banner.tsx

Line 28 in fbff48f

const mount = toMountPoint(

Looks like the theme needs to get added to the toMountPoint call.

This might have a relation to #118866 as well.
@matschaffer matschaffer added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@matschaffer matschaffer mentioned this issue Sep 1, 2022
Closed
@pgayvallet pgayvallet self-assigned this Sep 1, 2022
@pgayvallet pgayvallet mentioned this issue Sep 1, 2022
Merged
@matschaffer
Copy link
Contributor Author

I booted 7.17 in dark mode today for another issue and saw that the banner is a much more expected shade of blue.

Screen Shot 2022-09-05 at 14 33 58

@matschaffer matschaffer changed the title OptInBanner is rendering without theme, so always light-mode OptInBanner is rendering without theme, so always light-mode, no dark mode Sep 5, 2022
@matschaffer matschaffer changed the title OptInBanner is rendering without theme, so always light-mode, no dark mode OptInBanner is rendering without theme, no dark mode support Sep 5, 2022
@matschaffer matschaffer mentioned this issue Sep 5, 2022
Open
@pgayvallet
Copy link
Contributor

Yea, will be fixed by #139911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use theme for the telemetry opt-in banner pgayvallet/kibana
3 participants
@matschaffer @pgayvallet @elasticmachine