Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Able to create a rule by adding only a filter without adding any query #139080

Closed
ghost opened this issue Aug 18, 2022 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.4.0

Comments

@ghost
Copy link

ghost commented Aug 18, 2022

Describe the bug
Able to create a rule by adding only a filter without adding any query

Build info

VERSION : 8.4.0 BC5
BUILD: 55374
COMMIT: f12954223a8ad66bbbf77becc4f0557ffd1c92c3

Preconditions

  1. Kibana should be running

Steps to Reproduce

  1. Navigate to security > Rules page
  2. Click on create a new rule
  3. Add any filter, but does not add any query
  4. Observe that preview result buttin is disable
  5. Now create the rule and observe that rule is created without any query

Actual Result
Able to create a rule by adding only a filter without adding any query

Expected Result
User should not be able to create the rule without adding any query
Or
Preview button should be enable if user is able to create a rule by adding only a filter without adding any query

Screen-cast

rule.with.filter.mp4

rule.zip

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 labels Aug 18, 2022
@ghost ghost self-assigned this Aug 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned banderror and unassigned ghost Aug 18, 2022
@banderror
Copy link
Contributor

@deepikakeshav-qasource I think this behavior is expected and correct. If the user specifies at least one filter, it will be used to build the final rule's query when the rule runs, so that query in the UI can be left empty. Query in the UI must be specified only if the user doesn't add any filters.

@peluja1012 please correct me if I'm wrong.

@ghost
Copy link
Author

ghost commented Aug 22, 2022

Hi @banderror,

Thank you for sharing details!!

If this is expected, Then we can enable the preview results button as well if user is able to create a rule by adding only a filter without adding any query!!

Thank you!!

@banderror
Copy link
Contributor

Then we can enable the preview results button as well if user is able to create a rule by adding only a filter without adding any query!!

++ That makes sense to me @deepikakeshav-qasource 👍 May I ask you to please open a separate bug for that?

@ghost
Copy link
Author

ghost commented Aug 22, 2022

Hi @banderror ,

We have opened a separate bug for preview Results.

We are good to close this ticket as it is working as expected.

Please let us know if any other action is required on this ticket.

Thanks you!!

@banderror
Copy link
Contributor

I'm going to double-check with @peluja1012 later today if we can close this one. Thank you!

@banderror
Copy link
Contributor

Alright, we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.4.0
Projects
None yet
Development

No branches or pull requests

2 participants