-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] [R&D] Prototype Log Explorer mode for Discover #134764
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
ℹ️ I updated the description with the current progress |
ℹ️ Status update⚙️ What works in the prototype
🔮 The path forwardScenario 1: Separate log explorer mode
Advantages
Disadvantages
Scenario 2: Refactor main discover state management
Advantages
Disadvantages
High level diagram / overviewThis is a high level (not 100% exhaustive) overview of the structure based on the prototype, and where we have sharability and divergences with Discover. |
I saw this in the "In Review" column, so I figured I'd mention my ¥2.81 would be to go with scenario 2 since it avoids special cases and divergence. Though I'm sure there's a conversation to be had with discover maintainers to see how we can weave that into other efforts. |
I agree that scenario 2 would have plenty of advantages, but also like Felix mentions correctly:
maybe we find a way to follow scenario 1 to tech preview (with increasing the common shared code) before we can go to scenario 2 which is a pretty big change in Discover |
KUDOS for this great diagram, that I think @Kerry350 drew? |
Indeed, conversations are ongoing with the Discover folks.
This seems like a good compromise. My preference would also be scenario 2, but I appreciate there is a huge planning overhead. Pushing the POC to a preview state with no (that we know of 👀) bugs, and trying to share even more code seems like a fair next step. One thing to mention is that Felix and I were keen to stay involved, and not just dump this on the Discover team.
Thanks! Yeah, that was me. I'm sorry it wasn't 100% finished, I ran out of time before the demo. But I still have the excalidraw file if there's value in adding to it later. |
Done! 🚀 |
Summary
As part of #134412 we want to investigate the feasibility of having a Log Explorer mode in Discover.
POC Goals
ℹ️ This list is not a strict set of acceptance criteria but an enumeration of features potentially worth demonstrating. We may decide to add additional features or skip listed features as the investigation progresses.
<EuiDataGrid>
such that...onGridItemsRendered
support)search_after
with a unique tiebreaker, async search with cancellation)🎨 Preview screenshots
Areas of investigation
Preliminary setup
We will need to setup any changes behind a feature flag.
There should be some sort of toggle to switch in to Log Explorer mode. There is no need for the UI / UX behind this to be perfect at this stage, as it will be hidden behind a flag. We can probably just pop it as an option here for now:
Visual investigation
EUI DataGrid
Investigations into enhancements for the DataGrid will be happening in #79288. We should consider how those API changes will interact with this new Log Explorer.
Histogram sidebar
E.g.:
Are there any technical advancements (be it in EUI, native JS functionality etc) that we can take advantage of for the Logs histogram / minimap sidebar?
How should this sidebar be integrated in to the Discover page?
Data investigation
search_after
to incrementally load results (and a reversedsearch_after
to achieve a "before" search). Discover does not usesearch_after
currently. We should investigate the query and data usage:search_after
, or should the two converge? (e.g. the document explorer would also use this new query mechanism)The text was updated successfully, but these errors were encountered: