Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Format rolled up metrics correctly in doc table #134224

Closed
flash1293 opened this issue Jun 13, 2022 · 5 comments · Fixed by #138205
Closed

[Discover] Format rolled up metrics correctly in doc table #134224

flash1293 opened this issue Jun 13, 2022 · 5 comments · Fixed by #138205
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WIP Work in progress

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jun 13, 2022

Rolled up metric fields in TSDB indices will not return a single number, but a stats object - instead of

  myField: [4]

it will look like this:

  myField: [{ min: 0, max: 3, sum: 12, count: 17 }]

Discover should detect this case and render the object in the doc table in a nice way (as JSON or maybe with the existing _source formatter)

How to start development

@flash1293 flash1293 added Feature:Discover Discover Application enhancement New value added to drive a business result Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor

Hi @flash1293
Could you please provide some steps how we can recreate this state locally and to see metric fields on Discover page? Thanks!

@flash1293
Copy link
Contributor Author

Hi @jughosta , this isn't done yet from the Elasticsearch side, but AFAIK @csoulios is actively working on it right now. @csoulios is there already a PR to link to or something?

@csoulios
Copy link

@csoulios is there already a PR to link to or something?

I haven't pushed a PR yet. I will add a link here when I submit the PR.

@csoulios
Copy link

@salvatore-campagna pushed PR elastic/elasticsearch#88534 to support this from ES side.
However, this is a breaking change so it takes some time to merge into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants