Rules View to use Shareable Components

[emma-raffenne]

Dependencies

• [RAM] Add shareable rules list #132437
• [RAM] add columns selector from EuiDatagrid into rules list #135287
• [RAM] Bulk Actions for Alerts Table #135716 - from @elastic/response-ops

Description

Rules view must use available shareable components provided by platform.

Implementation

• Use the shareable component for rules tables
  • Table should show only o11y rule types
  • Filter by type should show only the o11y rule types
  • Hide action type filtering
  • Rule to o11y rule details page is broken
  • Hide Create rule button
  • Add a Refresh button
  • Remove duplicate code from observability plugin
  • Persist View and Last response filtering in the urlbar

[mgiota]

@emma-raffenne For the 1st subtask Use the shareable component for rules tables we also need an update from Response Ops regarding what's the progress on the shareable Rules table and if they need our help on the implementation.

@JiaweiWu I can see this Meta issue #129932 is Closed. Does this mean the rules table is already shareable? cc @XavierM

UPDATE
Here's the merged shareable rules table PR

[mgiota]

I used the shareable rules table in its current state and here is the status:

• Table shows rules from all rules types (stack and security ones as well)
• Filter by type shows all rule types.
• Action type filtering is visible
• Rules link to the Stack Management page
• Double create rule button
• Filtering is not persisted in the urlbar and as a result linking from Stats in the Alerts page doesn't work anymore.

I updated the description with the things that need to be changed accordingly.

A few more design observations:

• columns are not parameterized, which means that o11y rules page will have more columns than it currently has (P50, success rate, interval)
• Refresh button is removed. An autorefresh button appears instead
• Bulk actions and overflow actions still use Mute, Unmute terminology
• Overflow actions -> what is update API key? Does it need to be here for o11y?

Here's a video showing current status of Shareable Rules table in observability:

Screen.Recording.2022-06-14.at.13.28.54.mov

cc @vinaychandrasekhar @liciavale @simianhacker

[mgiota]

@liciavale Regarding Refresh button which solution do you recommend?

1. Refresh button next to the filters as it appears in the figma file (Original ticket)

2. A small refresh button next to the autorefresh button. In this case I will need either a design with the icon and the exact location of the refresh button or concrete instructions on how it should look like (for example on the left of the Updated 3 minutes ago text, on the right of the autorefresh icon or wherever you think is better, regarding icon should it say Refresh or should it have a simple icon).

Here's an example of a Refresh button on a Security page.

[JiaweiWu]

@mgiota I'm very sorry I just saw this issue. For 8.3 parameterization was left out due to not having a concrete idea of what common props are desired, the focus was then placed on getting the rules list refactored and shareable. But now that you have tried the rules list, feel free to create a issue with the required parameters which I can work on.

[mgiota]

@JiaweiWu Thanks yep makes sense! Once you start having consumers, you can then know what needs to be parameterized. I am already working on the parameterization in a draft PR #134173 (I will clean it up and add more things into it next days), so I will definitely ask your review on this one. @XavierM is already working on parameterizing the columns.

[JiaweiWu]

ok great! sounds good to me, thank you!

[liciavale]

Hi @mgiota, thank you for your comment.
I think we should go with what we have in the figma file for now. This is what we are using also in the design of our alerts view and the important thing is that we keep it consistent in obs.

• Refresh button next to the filters as it appears in the figma file (Dedicated Rules view for Observability rules #119100)