Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Call to Action] Please Adopt new AnalyticsNoDataPage for no-data handling on Maps app #132147

Closed
Tracked by #111184
majagrubic opened this issue May 12, 2022 · 4 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps NeededFor:SharedUX needs-team Issues missing a team label

Comments

@majagrubic
Copy link
Contributor

majagrubic commented May 12, 2022

Background
As part of improving onboarding experience, the shared-ux team has taken on standardizing handling of no data state across Analytics apps. The goal is to have every Analytics app behave the same in case when there is no data in the ES cluster or no data views. Some additional context can be found in this meta issue and this tracking issue.

How?
We have developed AnalyticsNoDataPage component that distinguishes between "no data" and "no data views" state and renders the appropriate screen. It utilizes the new hasData service.

What you need to do?
Integrate this new component in your app. Example of how this was done for Discover can be found here

By when?
TBD

@botelastic botelastic bot added the needs-team Issues missing a team label label May 12, 2022
@majagrubic majagrubic added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label May 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 12, 2022
@majagrubic
Copy link
Contributor Author

cc @rayafratkina

@nreese
Copy link
Contributor

nreese commented May 12, 2022

I am not sure Maps application should show either. The Maps application allows adding layers from non-elasticsearch sources such as WMS and vector tiles, making maps usable without elasticsearch data and data-views.

@nreese nreese added the triage label May 12, 2022
@rayafratkina rayafratkina changed the title [Call to Action] Please Adopt new AnalyticsNoDataPage for no-data handling [Call to Action] Please Adopt new AnalyticsNoDataPage for no-data handling on Maps app May 12, 2022
@teresaalvarezsoler
Copy link

We agreed with the maps team that the NoDataPage should not apply to maps since users can upload a Geo JSON from the app itself and create a map without having ES data. Closing the issue.

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps NeededFor:SharedUX needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

5 participants