Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render TSDB rollup related shard failure warnings as part of the visulization instead of toast messages #132045

Closed
flash1293 opened this issue May 11, 2022 · 3 comments · Fixed by #136833
Labels
Feature:Lens Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

For TSDB it will become a common scenario to get partial data because rolled up indices do not support certain aggregations. As this is an expected behavior, it should not be handled like regular shard failures which indicate problems with the Elasticsearch cluster. Several things need to be adjust for this:

  • Finalize on a way to expose the information whether a failure is due to TSDB rollups with the Elasticsearch team
  • Recoginize these failures and pass them along with the datatable
  • Render them as warnings in dashboard panels (for agg based visualizations, TSVB, Timelion and Lens) and in the Lens editor

Part of this is implemented here: https://github.com/ppisljar/kibana/tree/onweek/tsdb

@flash1293 flash1293 added Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv Feature:Lens labels May 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor Author

As discussed with @ppisljar , the warnings will be passed along with the inspector and can be used by the editor and/or embeddable. To render warnings in a nice way on dashboards, the following approach can be taken (given the design is acceptable, cc @MichaelMarcialis ):

  • Out warnings to output of embeddable
  • Implement an action with a MenuItem which checks for the action (like library notification action) and renders a custom popover with the warnings in them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants