Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FullStory] Demote the deployment information to setVars instead of setUserVars #131704

Closed
Tracked by #121992
afharo opened this issue May 6, 2022 · 1 comment · Fixed by #132837
Closed
Tracked by #121992

[FullStory] Demote the deployment information to setVars instead of setUserVars #131704

afharo opened this issue May 6, 2022 · 1 comment · Fixed by #132837
Assignees
Labels
enhancement New value added to drive a business result Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented May 6, 2022

The way we treat users in FullStory they don't belong to a specific deployment because they can own multiple deployments.

For that reason, we shouldn't store the version and cloudId context at the user level. This issue is to demote these properties to call setVars instead of the current setUserVars:

The relevant piece of code:

// User-level context
if (version || cloudId) {
this.initContext.logger.debug(
`Calling FS.setUserVars with version ${version} and cloudId ${cloudId}`
);
this.fullStoryApi.setUserVars({
...(version ? getParsedVersion(version) : {}),
...(cloudId ? { org_id_str: cloudId } : {}),
});
}

NOTE: This change contains breaking changes and may affect any existing dashboards in FullStory.

cc @lizozom @elastic/platform-analytics

@afharo afharo added enhancement New value added to drive a business result Feature:Telemetry labels May 6, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label May 6, 2022
@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label May 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants