Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Remove inline awaits #13041

Open
stacey-gammon opened this issue Jul 21, 2017 · 0 comments
Open

[Tests] Remove inline awaits #13041

stacey-gammon opened this issue Jul 21, 2017 · 0 comments
Labels
chore Team:QA Team label for QA Team test

Comments

@stacey-gammon
Copy link
Contributor

We should make this part of our style guide as well, but inline awaits are confusing.

e.g. for the following statement is a() being awaited on, or b()?
await a().b()

To avoid this confusion we should just stop inlining awaits. The above usage is prolific in our tests when a() returns a promise, and I suspect causing some test instability.

@snide snide added the Team:QA Team label for QA Team label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:QA Team label for QA Team test
Projects
None yet
Development

No branches or pull requests

2 participants