Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Update edit policy form to use EuiTimeline instead of EuiComment #130302

Closed
yuliacech opened this issue Apr 14, 2022 · 3 comments · Fixed by #131732
Closed

[ILM] Update edit policy form to use EuiTimeline instead of EuiComment #130302

yuliacech opened this issue Apr 14, 2022 · 3 comments · Fixed by #131732
Assignees
@yuliacech
Labels
Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

EuiTimeline is a new EUI component that creates a vertical thread and can be used to display phases in the edit policy form. We should be able to delete our custom scss code in here and use this new component to get the same visuals. Also EuiComment component will be updated in the future that will prevent us from using it (username prop will only accept string and we currently use it for the switch to enable/disable phases).

Screenshot 2022-04-14 at 19 18 19
@yuliacech yuliacech added Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@elizabetdev
Copy link
Contributor

elizabetdev commented Apr 26, 2022 •
edited
Loading

@yuliacech once this PR is merged #130593 we can start the conversion to start using the new EuiTimeline component.

@yuliacech
Copy link
Contributor Author

Thanks a lot for keeping us updated, @miukimiu! This issue is now on our team's roadmap and I'll start working on it shortly.

@yuliacech yuliacech mentioned this issue May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

Labels
Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ILM] Refactor edit policy form to use EuiTimeline yuliacech/kibana
3 participants
@elizabetdev @yuliacech @elasticmachine