Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package base tsconfigs in packages #129691

Open
spalger opened this issue Apr 7, 2022 · 1 comment
Open

Package base tsconfigs in packages #129691

spalger opened this issue Apr 7, 2022 · 1 comment
Labels
impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Apr 7, 2022

Part of #128012 will be moving everything to packages, but I think we should move tsconfig.json base files into packages sooner rather than later. This will allow us to define a dependency in bazel on the base config file and get the deps listed in "types" along with the config.

For instance:
tsconfig.base.json references the following modules in it's types list, which means they will be loaded by any tsconfig file extending it:

  • node
  • jest
  • flot
  • jest-styled-components
  • @testing-library/jest-dom
  • @emotion/react/types/css-prop

It would be great if we took this opportunity to move the browser specific types to tsconfig.browser.json and properly extend the baseConfigs we actually need.

@spalger spalger added the Team:Operations Team label for Operations Team label Apr 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

2 participants