Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date histogram aggregation tests are never executed during the build process. #12953

Closed
nreese opened this issue Jul 18, 2017 · 0 comments
Closed

date histogram aggregation tests are never executed during the build process. #12953

nreese opened this issue Jul 18, 2017 · 0 comments
Assignees
@thomasneirynck
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent test

Comments

@nreese
Copy link
Contributor

nreese commented Jul 18, 2017 •
edited by thomasneirynck
Loading

The following tests are never executed during the build process.

  • src/ui/public/agg_types/__tests__/buckets/date_histogram/_editor.js
  • src/ui/public/agg_types/__tests__/buckets/date_histogram/_params.js

src/ui/public/agg_types/__tests__/buckets/date_histogram/_date_histogram.js is never included in any test file.

_editor.js clears the interval when the field is changed test is broken because the field selection input has changed so now a new field is not selected in the test.
@nreese nreese added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience v6.0.0-beta1 test labels Jul 18, 2017
@thomasneirynck thomasneirynck self-assigned this Jul 19, 2017
@thomasneirynck thomasneirynck mentioned this issue Sep 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasneirynck thomasneirynck

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @thomasneirynck @jimgoodwin