Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react@^17 #129095

Closed
2 tasks done
nickofthyme opened this issue Mar 31, 2022 · 8 comments · Fixed by #128239
Closed
2 tasks done

Upgrade to react@^17 #129095

nickofthyme opened this issue Mar 31, 2022 · 8 comments · Fixed by #128239
Labels
dependencies Pull requests that update a dependency file Team:DataVis Team label for DataVis Team

Comments

@nickofthyme
Copy link
Contributor

nickofthyme commented Mar 31, 2022 •
edited by markov00
Loading

Describe the feature:

React v17 was released over a 18 months ago on October 20, 2020.

EUI has been developing against react@^17 since elastic/eui#5584.

There is really no Team: ownership of this type of widely used dependency so any team willing to lead this initiative please add your Team: label.

There seems to be very limited and specific breaking changes from v16 to v17 relating to minor internal react implementations. See details in here.

Required Dependencies

I'm not sure what other libraries or dependencies would block this upgrade so please list any on this issue description below.

Last note is that react@18 was released recently on March 29th, 2022 so it could be worth the effort to skip v17 altogether to maximize the benefit of this work.
@nickofthyme nickofthyme added the dependencies Pull requests that update a dependency file label Mar 31, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 31, 2022
@rayafratkina rayafratkina added the Team:DataVis Team label for DataVis Team label May 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 26, 2022
@nickofthyme
Copy link
Contributor Author

@spalger any idea on how easy this would be? Or any know blockers?

@spalger
Copy link
Contributor

spalger commented Jun 13, 2022

I think getting to 17 should be pretty easy, but I feel like at this point we should just go to 18 which also doesn't have any breaking changes, just type issues I would expect.

@markov00
Copy link
Member

markov00 commented Jun 17, 2022 •
edited
Loading

@spalger can we assign this issue to your team? I think datavis doesn't have enough knowledge and time to work on this task, if not, who can be the owner?

@spalger
Copy link
Contributor

spalger commented Jun 20, 2022 •
edited
Loading

I took a look at this and I think we need to wait a while more. So many of our dependencies haven't even been updated to support React 17. An example of dependencies I'm concerned about:

  • react-vis
  • @storybook/*
  • enzyme-adapter-react-16
  • @elastic/react-search-ui-views
  • constate
  • many other react-* deps

If there is an urgent need from one team to get this going then, historically, it would be that teams responsibility to track down and get those dependencies replaced or pester/help get the upgrade done.

@thompsongl
Copy link
Contributor

FYI #128239 also exists

@nickofthyme nickofthyme linked a pull request Jun 23, 2022 that will close this issue
Bump React@17 #128239
Merged
@damikun
Copy link

damikun commented Jul 7, 2022

Can we update directly to 18 since that is major Stable release?

@spalger
Copy link
Contributor

spalger commented Jul 7, 2022

@damikun not until our deps are ready, many aren't even ready for react 17 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Team:DataVis Team label for DataVis Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump React@17 patrykkopycinski/kibana
7 participants
@spalger @markov00 @thompsongl @elasticmachine @nickofthyme @rayafratkina @damikun