[Accessibility] Edit buttons in Management Advanced Settings provide no context for screen reader

[aphelionz]

Currently, the edit buttons on the right read "edit" with no indication of what you're editing. They should read "Edit sort options," "edit date format", etc

[chrisronline]

Thanks for the call out here!

I'm not sure if showing the name of what you're editing will scale, as some of the options are quite long: search:queryLanguage:switcher:enable. Is it viable to only show up to a max width in the UI but leave the full text for the screen reader? Will that work?

[aphelionz]

Yep! The visually readable text and the audible text can be presented slightly differently. No problem there.

[chrisronline]

Okay great thanks!

[BigFunger]

@aphelionz: Which would be a better for the aria-label: 'Edit xPack:defaultAdminEmail' or 'Edit x pack default admin email'?

[aphelionz]

@BigFunger It depends on what the screen reader says out loud. I appreciate that the former, 'Edit xPack:defaultAdminEmail' is easier to code because it doesn't require transliterating any strings... so if that works, go for it! However if it sounds funky its going to confuse people and needs to be split up.

[BigFunger]

I'm going to post a PR with the strings transliterated. Check it out and post your comments there. Will link soon.