Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Re-enable and fix broken ML tests as result of new V3 Modules #128318

Closed
spong opened this issue Mar 22, 2022 · 5 comments · Fixed by #133510
Closed

[Security Solution][Detections] Re-enable and fix broken ML tests as result of new V3 Modules #128318

spong opened this issue Mar 22, 2022 · 5 comments · Fixed by #133510
Assignees
@xcrzx @banderror
Labels
8.3 candidate Feature:Detection Rules Security Solution rules and Detection Engine Feature:ML Rule Security Solution Machine Learning rule type impact:critical This issue should be addressed immediately due to a critical level of impact on the product. skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0

Comments

@spong
Copy link
Member

spong commented Mar 22, 2022 •
edited by banderror
Loading

With the introduction of the V3 ML Modules (#131166) some tests have been skipped and will need to be addressed within the 8.3.0 release. Current tests skips should be the following related to testing anomaly_threshold and react hooks for accessing security jobs. Most appear to be broken as a result of a job count mis-match or missing job as new jobs were introduced and older jobs were deleted.

Note: there's a cypress test skipped not captured in the screenshot about as well.
@spong spong added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:ML Rule Security Solution Machine Learning rule type Team:Detection Rule Management Security Detection Rule Management Team v8.2.0 labels Mar 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong added v8.3.0 and removed v8.2.0 labels Apr 11, 2022
@spong
Copy link
Member Author

spong commented Apr 11, 2022

Moving to 8.3 as the modules have been pushed to that version as well (#128099) .

@banderror
Copy link
Contributor

We'll need to fix the ML tests skipped in #128099 if they won't be fixed in this PR itself.

@spong spong mentioned this issue Apr 28, 2022
Merged
@banderror banderror self-assigned this May 4, 2022
@spong
Copy link
Member Author

spong commented May 26, 2022

Note: there's a cypress test skipped not captured in the screenshot about as well.

@xcrzx xcrzx mentioned this issue Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

@banderror banderror

Labels
8.3 candidate Feature:Detection Rules Security Solution rules and Detection Engine Feature:ML Rule Security Solution Machine Learning rule type impact:critical This issue should be addressed immediately due to a critical level of impact on the product. skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Re-enable broken ML tests xcrzx/kibana
4 participants
@xcrzx @spong @banderror @elasticmachine