Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCS test isn't loading the ccs kbnArchive #126953

Closed
LeeDr opened this issue Mar 4, 2022 · 4 comments · Fixed by #126970
Closed

CCS test isn't loading the ccs kbnArchive #126953

LeeDr opened this issue Mar 4, 2022 · 4 comments · Fixed by #126970
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:QA Team label for QA Team

Comments

@LeeDr
Copy link

LeeDr commented Mar 4, 2022

Describe the bug:
This test is loading the regular (not CCS) kbnArchive here https://github.com/elastic/kibana/blob/main/test/functional_ccs/apps/discover/_data_view_ccs.ts#L35
and unloading the same regular one here
https://github.com/elastic/kibana/blob/main/test/functional_ccs/apps/discover/_data_view_ccs.ts#L42

I guess we missed these in the review of #124586

@LeeDr LeeDr added bug Fixes for quality problems that affect the customer experience Team:QA Team label for QA Team labels Mar 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@LeeDr
Copy link
Author

LeeDr commented Mar 4, 2022

Actually, I think there might be a couple of problems.
That _data_view_ccs.ts test is testing that it can create the Data View from Discover, so I don't think it should be loading a kbnArchive at all? Certainly not one that already has the save data view already created.

@LeeDr
Copy link
Author

LeeDr commented Mar 4, 2022

But it also seems that if you don't have any existing data views, Discover just redirects you to http://localhost:5620/app/kibana_overview
Which I think is a bug

@cuff-links
Copy link
Contributor

Actually, I think there might be a couple of problems. That _data_view_ccs.ts test is testing that it can create the Data View from Discover, so I don't think it should be loading a kbnArchive at all? Certainly not one that already has the save data view already created.

So do you think we need to rewrite this test? I literally just ported it to use CCS but the test always took this form. @LeeDr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:QA Team label for QA Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants