[Fleet] Agent policy inputs id are not unique

[nchaulet]

Description

When do not use id for inputs in the generated agent policy we send to agent, we should probably fix that as id are expected to unique.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/services/package_policies_to_agent_inputs.ts/#L29

Currently we use the package policy id as the input id this cause problem with package policy with multiple inputs.

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[jlind23]

@jen-huang @joshdover
This issue is somehow problematic and has generated recently a lot of user problems.
@belimawr as a fix ready to be merged on the beats side.
@ph as a fix ready to be merged on the Elastic Agent / Fleet server side

The only missing piece is this one. We need to merge all PR in the same release and then backport it to 7.17.X

How can we make it our top priority?

cc @ruflin

cc @ph @belimawr

[jen-huang]

@jlind23 Thanks for raising, I don't think this requires a huge effort, I've added it to our current iteration.

Just to verify: we'd want to fix to land in 8.2, 8.1.x, 8.0.x, and 7.17.x?

[ph]

@jen-huang yes that would be the target, just a note theses ids need to stable, by stable I mean if a user edit the same integration the ids of the input stay the same.

This will also be useful later, for reporting health information for a specific input.

[jen-huang]

Thanks for the note about stable IDs @ph.

@jlind23, fix in #127343 was just merged, backports are in progress. Shall we merge the other PRs?

[jlind23]

@jen-huang thanks @jen-huang and @nchaulet for the work.
Yes we will merge other PRs!

[ph]

Thanks, I will move the other pr to get them merged.