Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Document Explorer table is no longer browser searchable for off screen content #125713

Closed
ghudgins opened this issue Feb 15, 2022 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ghudgins
Copy link
Contributor

Kibana version: 8.1

Elasticsearch version: 8.1

Server OS version: Elastic Cloud

Browser version: Chromium Edge 95

Browser OS version: OSX

Original install method (e.g. download page, yum, from source, etc.): Cloud

Describe the bug: You cannot "cmd/ctrl + F" for Discover content that's out of view for document explorer.

Steps to reproduce:

  1. Turn on doc explorer
  2. Find some unique text that's "below the fold" / off screen
  3. Scroll up so that unique text is out of view
  4. Cmd/ctrl + f (browser find) for the unique text

Result: you cannot find the unique text

Expected behavior: You can find the unique text (this used to work on legacy table)

@ghudgins ghudgins added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@shaunmcgough
Copy link

Great find. This is going to be an issue for some users. It's hard to say what percentage, but the browser find is a common use case. There was some discussion yesterday with @kertal about level of effort, and it seems like it might be high. This seems like a regression, with the caveat that there is 3rd party interference here.

@shaunmcgough shaunmcgough changed the title [Discover] Doc explorer table is no longer browser searchable for off screen content [Discover] Document Explorer table is no longer browser searchable for off screen content Feb 16, 2022
@ghudgins ghudgins added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 16, 2022
@kertal
Copy link
Member

kertal commented Feb 17, 2022

A note about that, it also didn't work 100% with classic table. Why? in classic table 50 records are rendered by default, by scrolling down more records are rendered. The number of records rendered by Document explorer depends on the given screen height. So one solution would be: Buy a huge screen and rotate it 90°. In this case you might find more records using "cmd/ctrl + F". But this wouldn't be a good solution for sure. Just wanted to say: Fixing this would be more an enhancement then fixing a bug.

@kertal
Copy link
Member

kertal commented Nov 24, 2022

closing this in favor of #70799, because search among fetched result would be a way to improve this

@kertal kertal closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants