Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBT] Success-rate telemetry #125694

Closed
Tracked by #121992
afharo opened this issue Feb 15, 2022 · 6 comments · Fixed by #131644
Closed
Tracked by #121992

[EBT] Success-rate telemetry #125694

afharo opened this issue Feb 15, 2022 · 6 comments · Fixed by #131644
Assignees
Labels
Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Feb 15, 2022

Since we are taking some shortcuts in the implementation of the MVP, ideally, we should report some telemetry around the success & drop rates we are getting with the current approach so that we can adapt in the future

@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 15, 2022
@afharo afharo added Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Feb 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 15, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Feb 15, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 8, 2022
@afharo
Copy link
Member Author

afharo commented Apr 29, 2022

@Bamieh as you know best about UI/Usage Counters, I'd like to bring you in to discuss how to best map the telemetryCounters$ to UI/Usage Counters.

We need to think about how to map the type (succeeded/failed/dropped), source (client or shipper name), event_type and code into counterName and counterType

It feels like type and code could be concatenated and reported as counterType. However, I'm not entirely sure about how to deal with the other 2 levels.

For Usage Counters we have domainId, so I guess we could set the source to it?
However, on the UI Counters, appName and eventName are concatenated into the counterName so we'll have shipperName:eventType in the counterName and uiCounters in the domainId.

Is that OK?

@TinaHeiligers do you think we could add any piece of logic in the indexer to split uiCounters to break the appName:eventName concatenation into separate fields?

@TinaHeiligers
Copy link
Contributor

do you think we could add any piece of logic in the indexer to split uiCounters to break the appName:eventName concatenation into separate fields?

My instinct and from the little I've worked with splitting events, I think it should be possible. I'd defer to @haywoood for an expert opinion though.

@haywoood
Copy link

haywoood commented May 2, 2022

it should be possible

Yea, not a problem 🙂

Feel free to hit me up whenever this gets worked on if you need a second pair of eyes, or to talk through implementation specifics.

@TinaHeiligers
Copy link
Contributor

@afharo, for ui_counters we don't have a counterName though, we only have a counterName for usage_counters. Am I missing something from here?

@afharo
Copy link
Member Author

afharo commented May 5, 2022

@afharo, for ui_counters we don't have a counterName though, we only have a counterName for usage_counters. Am I missing something from here?

Sorry! I was looking at the Usage Counters definition. I meant appName. But I think we should be fine. Nevermind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants