Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update annotation method assumes annotation is in current write index #125281

Closed
peteharverson opened this issue Feb 10, 2022 · 1 comment · Fixed by #126573
Closed

[ML] Update annotation method assumes annotation is in current write index #125281

peteharverson opened this issue Feb 10, 2022 · 1 comment · Fixed by #126573
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v8.1.0 v8.2.0

Comments

@peteharverson
Copy link
Contributor

The function used for updating annotations in ML assumes that the annotation being updated is in the index that the annotations write alias currently points to. This assumption is incorrect. The annotation to be updated could be in any one of the indices that the annotations read alias points to. The result of the current behavior, is that when updating an annotation which was created before an upgrade to 8.0.0 for example, a new annotation is created rather than an update to the existing document.

A similar approach should be taken to that used when deleting annotations, implemented in #115328, where an extra query is performed against the read alias to obtain the index the annotation is stored in.

@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience :ml Feature:Anomaly Detection ML anomaly detection v8.2.0 labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants