Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing privileges in agent logs (Superuser removal enhancement) #124529

Open
criamico opened this issue Feb 3, 2022 · 3 comments
Open

Missing privileges in agent logs (Superuser removal enhancement) #124529

criamico opened this issue Feb 3, 2022 · 3 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0

Comments

@criamico
Copy link
Contributor

criamico commented Feb 3, 2022

Describe the feature:
With the merge of #108252, in the Agent details view the logs will always show There are no logs messages to display even in the case that the user actually has logs but they just don’t have the required privileges to read them.

Screenshot 2022-02-03 at 15 04 39

We want to give the user a better indication of the problem. The proposed mock up is the following, it should explain the actual reason for the absence of logs when user doesn't have the privileges. It should also hide inactive filter controls.

Screenshot 2022-02-03 at 15 06 55

Agent logs component

In order to do this change, some further investigation is needed to detect the user privileges, and for this reason this enhancement will probably be shipped after 8.1.

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

criamico commented Feb 3, 2022

@mostlyjason @joshdover we discussed to replace Try adjusting your filter with Try adjusting your filter or checking your index privileges for 8.1, but the string for this subtext is in the infra plugin.

I could open a PR there or I could try to make a change in Fleet, but both of them would be a workaround until we determine the right privilege for the user. What do you suggest in this case?

@criamico criamico changed the title Missing privileges in agent logs (enhancement) Missing privileges in agent logs (Superuser removal enhancement) Feb 3, 2022
@joshdover
Copy link
Contributor

I think it's ok if we work on the actual enhancement we want to do in 8.2 as a small task and don't mess with changing the copy since it's not Fleet-specific right now.

We can reduce confusion here with documentation around how to configure these roles (add read index privileges for logs-elastic_agent.*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

No branches or pull requests

4 participants