Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] "Upgrade integration" shown when editing APM package policy #121427

Closed
hop-dev opened this issue Dec 16, 2021 · 3 comments
Closed

[Fleet] "Upgrade integration" shown when editing APM package policy #121427

hop-dev opened this issue Dec 16, 2021 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v7.16.1 v7.16.2 v8.0.0 v8.1.0

Comments

@hop-dev
Copy link
Contributor

hop-dev commented Dec 16, 2021

Kibana version: 7.16, 8.0, 8.1

Description of the problem including expected versus actual behavior:

Incorrect version of the package policy editor is shown when editing the APM package policy.

Steps to reproduce:

  1. Install the APM integration and add it to an agent policy
  2. Select edit integration from the agent policy view
  3. Notice the package policy editor shows the upgrade layout instead of the edit layout.
Kapture.2021-12-16.at.16.36.31.mp4
@hop-dev hop-dev added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.1.0 v7.16.1 v7.16.2 labels Dec 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover
Copy link
Contributor

This is intentional and specific to custom editor UIs that opt in to this behavior: #114914

The point of this feature was to simplify custom editor UI implementations by allowing them to only have to support the schema for their latest package policy. This is acceptable for these editors because these packages are always upgraded on Kibana upgrade but the package policies are not always upgraded. When a user edits one of these packages we force them into upgrading the policy as well to simplify the testing matrix.

Feel free to re-open if I'm misunderstanding!

@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 16, 2021

Ah you're right @joshdover, though looks like Kyle did identify further work here which is covered by this issue: #115638 Still correct to close this bug 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v7.16.1 v7.16.2 v8.0.0 v8.1.0
Projects
None yet
Development

No branches or pull requests

3 participants