Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Application not found error comes up while adding an agent through newly created security integration #120736

Closed
muskangulati-qasource opened this issue Dec 8, 2021 · 9 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0

Comments

@muskangulati-qasource
Copy link

Description:
'Application not found' error comes up while adding an agent through newly created security integration

Build Details:

Kibana version: 8.0.0 SNAPSHOT
Build: 48631
Commit: 8a3953e7f42d682df737e355bebe6ffc7816d3bd
Artifact page: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT

Browser Details:
All

Preconditions:

  1. Kibana user should be logged in.

Steps to Reproduce:

  1. Navigate to the Endpoint tab under the Manage section under Security from the left side navigation on Kibana
  2. Add a new policy for Security integration
  3. After adding the policy, click on the 'Add host to the integration' button
  4. Observe that the user is thrown with an error for the tab

Impacted Test case:
N/A

Actual Result:
'Application not found' error comes up while adding an agent through newly created security integration

Expected Result:
Users should be able to add a new host via the same button

What's working:
N/A

What's not working:
N/A

Screen Recording:

Add.Agent.mp4

Logs:
N/A

@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience v8.0.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Dec 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@muskangulati-qasource
Copy link
Author

@manishgupta-qasource please review!

@manishgupta-qasource
Copy link

Reviewed & assigned to @kevinlog

@kevinlog
Copy link
Contributor

kevinlog commented Dec 8, 2021

@jen-huang @joshdover - I took a look at this. It seems like the way that we determine the return routes in this flow changed from 7.16 to 8.0.0 .

I took a look at this area in the code: https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx#L299

We use an appId to calculate the return route, however in 8.0.0 it seems like the appId itself is appended to the return around as opposed to what it should translate to, i.e. security.

The difference is this:
return route created in 7.16.0: /app/security/administration/endpoints
return route created in 8.0.0: /app/securitySolution/administration/endpoints (is not a valid app and leads to the bug).

Did anything change in this area of the app?

FYI @paul-tavares - did anything change on our end?

@kqualters-elastic
Copy link
Contributor

kqualters-elastic commented Dec 9, 2021

@kevinlog there was a change recently that added an app id for the security solution ui that's different from the one we had been using previously, https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/common/constants.ts#L20 . if you use this const instead of however state is passed to https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx#L299 , it should work. the reason you see securitySolution is because that's how navigateToApp fails with an arbitrary string that's not an actual app id.

Another issue with the same root cause that fails in the same way: #120711

@kevinlog
Copy link
Contributor

kevinlog commented Dec 9, 2021

thanks @kqualters-elastic !

@paul-tavares I now have a PR for this: #120897

@kevinlog kevinlog added OLM Sprint QA:Ready for Testing Code is merged and ready for QA to validate labels Dec 9, 2021
@jen-huang
Copy link
Contributor

Closing as #120897 was merged.

@amolnater-qasource
Copy link

Hi @jen-huang
We have revalidated this issue on latest 8.1 BC-4 Kibana cloud environment and found it fixed.

  • No Application not found error and user is redirected to Endpoints tab while adding an agent through newly created security integration

Build details:
VERSION: 8.1.0
BUILD: 50428
COMMIT: 015578b

Screen Recording:

Administration.-.Kibana.-.Google.Chrome.2022-02-25.12-58-26.mp4

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0
Projects
None yet
Development

No branches or pull requests

7 participants