Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regionmap lens icon #120682

Closed
nreese opened this issue Dec 7, 2021 · 8 comments
Closed

regionmap lens icon #120682

nreese opened this issue Dec 7, 2021 · 8 comments
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@nreese
Copy link
Contributor

nreese commented Dec 7, 2021

Maps team is working on adding a regionmap visualization that would use MapEmbeddable to render a regionmap against EMS layers. This work will require an icon that will be displayed in the lens "Visualization type" drop down and lens "Suggestions". I am currently using the maps choropleth icon from https://github.com/elastic/kibana/blob/main/x-pack/plugins/maps/public/classes/layers/wizards/icons/cloropleth_layer_icon.tsx.

This existing icon is a good place to start, just need it to be colored in the similar scheme as the lens icons and maybe make it a little smaller.

Screen Shot 2021-12-07 at 1 48 37 PM

cc @ryankeairns

@nreese nreese added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Dec 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@MichaelMarcialis
Copy link
Contributor

Hey, @nreese. I've put together a quick region map icon for you to use in the Lens visualization selector. The SVG is available for download from my Google Drive. Let me know if this will work for you. Thanks!

image

@nreese
Copy link
Contributor Author

nreese commented Dec 9, 2021

@MichaelMarcialis Thanks for putting together an icon. Is there anyway we could make the following changes?

  • The large gaps between dark areas look more like rivers or roads then administrative boundaries and do not give a good representation of what a regionmap visualization looks like
  • Would it be possible to show some graduation in greys wrt shapes, See image below for what the product looks like. It would be nice if the icon better matches the visualization
  • Can you remove the placemark? The placemark is very misleading. A placemark tends to mean an actual location on a map. Regionmaps do not show actual locations, but instead shade areas to compare statistics across boundaries.

We really like the icon used in maps for regionmap and are hoping to get something that looks similiar in lens so users can see they are the same thing.
Screen Shot 2021-12-09 at 3 20 20 PM

Screen Shot 2021-12-09 at 3 16 32 PM

@MichaelMarcialis
Copy link
Contributor

  • The large gaps between dark areas look more like rivers or roads then administrative boundaries and do not give a good representation of what a regionmap visualization looks like

What looks like large gaps in the zoomed-in screenshot above will actually be quite small when implemented in Lens, as the icon is only used at small sizes throughout the interface (much smaller than what the Maps app uses for their icons). As such, the icon needs to be able to scale down without losing some of the finer details (on both high and low pixel density displays). Please see the mockup below of the same icon in use in the chart picker button and menu in Lens where it will be used as an example.

  • Would it be possible to show some graduation in greys wrt shapes, See image below for what the product looks like. It would be nice if the icon better matches the visualization

For the sake of being consistent with all other Lens chart icons, my recommendation is that we should stick to utilizing the two colors (one gray, one green accent). Also, again, as this icon needs to scale down to a fairly small size, it's likely that any subtle gradation of grays will be missed entirely in the final product.

  • Can you remove the placemark? The placemark is very misleading. A placemark tends to mean an actual location on a map. Regionmaps do not show actual locations, but instead shade areas to compare statistics across boundaries.

The intent for the inclusion of the map pin to the icon was in anticipation of additional map types being offered in the future for the chart picker. Assuming I'm correct that additional map types will be offered in the future, I was hoping to use the map pin addition to each map icon as a means to bind them together visually (as a grouping of map icons). Let me know if you still wish to remove the pin despite that.

image

@nreese
Copy link
Contributor Author

nreese commented Dec 13, 2021

Thanks for showing the logo in product. That helps provide better context.

  • I still think the icon should not have a placemark in it for the reasons stated above. If the regions look map like, then the placemark is not really needed and the icon will look like a map.
  • It would be great if the different regions could be colored. Sticking to 2 colors is fine to match the other icons. Maybe the icons could show 3 to 5 regions and color most of them gray except for one or two with a green accent. Take a look at the heat map icon. Regionmap is very similar concept except that the regions are geographical instead of aligning with x and y axis.

Screen Shot 2021-12-13 at 10 21 10 AM

@MichaelMarcialis
Copy link
Contributor

@nreese: Based on the feedback from the #maps Slack channel and my initial instincts, I think it'd be best if we proceed with the region map icon below (as it both addresses your feedback and reduces down better than the other options). Let me know if you have any questions/concerns. Otherwise, feel free to use. Thanks!

image

image

@nreese
Copy link
Contributor Author

nreese commented Mar 3, 2022

Closing, using provided icon with lens choropleth chart #126819

@nreese nreese closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

3 participants