-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regionmap lens icon #120682
Comments
Pinging @elastic/kibana-gis (Team:Geo) |
Pinging @elastic/kibana-design (Team:Kibana-Design) |
Hey, @nreese. I've put together a quick region map icon for you to use in the Lens visualization selector. The SVG is available for download from my Google Drive. Let me know if this will work for you. Thanks! |
@MichaelMarcialis Thanks for putting together an icon. Is there anyway we could make the following changes?
We really like the icon used in maps for regionmap and are hoping to get something that looks similiar in lens so users can see they are the same thing. |
What looks like large gaps in the zoomed-in screenshot above will actually be quite small when implemented in Lens, as the icon is only used at small sizes throughout the interface (much smaller than what the Maps app uses for their icons). As such, the icon needs to be able to scale down without losing some of the finer details (on both high and low pixel density displays). Please see the mockup below of the same icon in use in the chart picker button and menu in Lens where it will be used as an example.
For the sake of being consistent with all other Lens chart icons, my recommendation is that we should stick to utilizing the two colors (one gray, one green accent). Also, again, as this icon needs to scale down to a fairly small size, it's likely that any subtle gradation of grays will be missed entirely in the final product.
The intent for the inclusion of the map pin to the icon was in anticipation of additional map types being offered in the future for the chart picker. Assuming I'm correct that additional map types will be offered in the future, I was hoping to use the map pin addition to each map icon as a means to bind them together visually (as a grouping of map icons). Let me know if you still wish to remove the pin despite that. |
Thanks for showing the logo in product. That helps provide better context.
|
@nreese: Based on the feedback from the #maps Slack channel and my initial instincts, I think it'd be best if we proceed with the region map icon below (as it both addresses your feedback and reduces down better than the other options). Let me know if you have any questions/concerns. Otherwise, feel free to use. Thanks! |
Closing, using provided icon with lens choropleth chart #126819 |
Maps team is working on adding a regionmap visualization that would use MapEmbeddable to render a regionmap against EMS layers. This work will require an icon that will be displayed in the lens "Visualization type" drop down and lens "Suggestions". I am currently using the maps choropleth icon from https://github.com/elastic/kibana/blob/main/x-pack/plugins/maps/public/classes/layers/wizards/icons/cloropleth_layer_icon.tsx.
This existing icon is a good place to start, just need it to be colored in the similar scheme as the lens icons and maybe make it a little smaller.
cc @ryankeairns
The text was updated successfully, but these errors were encountered: