-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display event loop delay histogram data in the Status page #120667
Comments
Pinging @elastic/kibana-core (Team:Core) |
How should we display the data? @pgayvallet @lukeelmers I'm leaning toward the second option of showing the percentiles as a card footer:
|
I don't have strong feelings on this, but my initial reaction is that option 2 makes the most sense as well (just using the existing delay card, maybe also including the actual 50, 95, 99 percentiles for clarity). I don't think we need to get particularly fancy with this; IMO the main thing is just showing the data somewhere. |
I like the option
I'd improve |
FWIW, this cards layout (and the whole I'd probably go with |
We could use the footer as a plain text rather than the MetricCard as a once-off conditional for now if we also want this to land in 7.17.0 (the option that doesn't stretch the card). Which versions should we be targeting here? I'm guessing 7.17 + based on the target version for adding the percentiles to the logs.
Building some generic card components that could expand as an option in the footer or similar to the actions we have in the Saved Objects Table could be an option. Or some way on expanding a card to show more detail. As to where and how to show the extra detail, ya, we'll need design-guidance. |
A couple of quick ideas:
It is an awful lot of panels, but short of doing a mockup (in the future) these tweaks may get you by for now. |
@ryankeairns Do you have any suggestions on how to best display an odd number of metrics? We used to have 6 that aligned nicely on two rows or three each but now we're adding another one to make it 7. We could group a few more of the existing metrics into one card (response time ave & response time max, heap used & heap total) but then we'd again end up with an odd number of entries to display. @pgayvallet How does this look to you: It's no where perfect but we'll probably do a whole redesign anyway when the status page has a "home" in Kibana's nav, if not sooner. |
@TinaHeiligers +1 to spending some time on a redesign in the near future. It would be best to work through a few options and discuss which metrics are related, etc. Short of that, it's going to remain a bit messy. |
Like it would still greatly benefit from a design rework as you said. However this is WAY better than the initial screenshots, so it will do perfectly for now in my opinion. EDIT: posted at the exact same time as @ryankeairns. If we all think we should revisit this page's design, we can also wait until doing so before adding the new metrics. But adding them now and then thinking about the design would also allow to have all the metrics in the current page to think about the re-design, so it's probably for the best? |
@pgayvallet The PR is ready for review: #121052 |
To be clear, I'm good with adding metrics now and doing design work later. Just reach out once it's been prioritized on your end and we can slot in some designer time. |
In v7.x, we enhanced the
ProcessMetricsCollector
to report the the event loop delay distribution as well as the mean. These additional metrics help with monitoring and diagnosing performance, because they can be used to roughly estimate the number of cycles that went above the mean for the deployment.To help diagnose performance problems, we added a subset of the percentile distribution to the
metrics.ops
logger that we could monitor and use if needed.We should add these to the
status
page as supplemental info to the mean.The text was updated successfully, but these errors were encountered: