Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Compatibility shim for generating PDF reports using 6.2 URLs can be removed. #120192

Closed
tsullivan opened this issue Dec 2, 2021 · 2 comments · Fixed by #121369
Closed

[Reporting] Compatibility shim for generating PDF reports using 6.2 URLs can be removed. #120192

tsullivan opened this issue Dec 2, 2021 · 2 comments · Fixed by #121369
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

Code cleanup issue

According to telemetry data, this code is no longer accessed by users.

kibana/x-pack/plugins/reporting/server/export_types/printable_pdf/create_job/compatibility_shim.ts

Lines 51 to 55 in 8695632

/*
* The compatibility shim is responsible for migrating an older shape of the
* PDF Job Params into a newer shape, by deriving a report title and relative
* URL from a savedObjectId and queryString.
*/

It should be removed as there are quite a few tests that will be able to go away as a result.
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Reporting Services labels Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

This was referenced Dec 2, 2021
Closed
Closed
@exalate-issue-sync exalate-issue-sync bot added the loe:small Small Level of Effort label Dec 2, 2021
@tsullivan tsullivan mentioned this issue Dec 15, 2021
Closed
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Dec 15, 2021
@tsullivan tsullivan mentioned this issue Dec 16, 2021
Merged
2 tasks
@exalate-issue-sync exalate-issue-sync bot changed the title [Reporting] Compatibility shim for generating reports using 6.2 URLs can be removed. [Reporting] Compatibility shim for generating PDF reports using 6.2 URLs can be removed. Dec 16, 2021
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] remove legacy pdf shim tsullivan/kibana
3 participants
@tsullivan @sophiec20 @elasticmachine