Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Offer option to extend auto-extend histogram and date histogram operations #119474

Closed
flash1293 opened this issue Nov 23, 2021 · 1 comment · Fixed by #127453
Closed

[Lens] Offer option to extend auto-extend histogram and date histogram operations #119474

flash1293 opened this issue Nov 23, 2021 · 1 comment · Fixed by #127453
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Currently some charts behave sub-optimal because the data table passed to the chart does not contain empty rows with a null value for some empty buckets (no documents). As this is a good use case in some cases, in most cases it causes confusing behavior (like #100301)

To unify the existing behavior without breaking backwards compatibility as far as feasible, the following steps have to be completed:

  • Finish implementation for auto-extending number histogram by queried min and max values: Add new autoExtendBounds setting to histogram agg config #118855
  • In Lens histogram, add an advanced setting switch "Include empty table rows" (with a tooltip to explain a bit). This is set to false for existing histograms (via migration) but set to true for newly created histograms. If set to true, it sets min_doc_count to false and enables the auto extend option from above
  • In Lens date histogram, we always included empty rows, but didn't expand to the data range so far. Here, add advanced setting switch "Include empty table rows" (with a tooltip to explain a bit). This is set to true for existing date histograms (via migration) as well as newly created date histograms but can be turned off. It controls the min_doc_count setting and also extends the range to the currently selected time range. This last part is not backwards compatible - we are taking away the current setting of keeping empty buckets, but only in between buckets with data. I think this is fine because there's no good use case for this intermediate step.
@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants