Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring UI] Use the official KibanaThemeProvider #118906

Closed
weltenwort opened this issue Nov 17, 2021 · 3 comments · Fixed by #120713
Closed

[Stack Monitoring UI] Use the official KibanaThemeProvider #118906

weltenwort opened this issue Nov 17, 2021 · 3 comments · Fixed by #120713
Assignees
Labels
Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.1.0

Comments

@weltenwort
Copy link
Member

📓 Summary

In order to support the new theming mechanism of EUI we need to include the recently added <KibanaThemeProvider> in the app component hierarchy.

part of #118866

✔️ Acceptance criteria

  • The function that mounts the react hierarchy of the monitoring app wraps the hierarchy into a <KibanaThemeProvider> with props from the core theme$ argument.

💡 Implementation hints

@weltenwort weltenwort added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring v8.1.0 labels Nov 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jasonrhodes
Copy link
Member

Do we know if this has an explicit deadline when it needs to be done?

@weltenwort
Copy link
Member Author

The meta issue indicates that EUI will rely on this provider to be present by 8.1 FF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants